Re: [Xen-devel] [PATCH 03 of 16 RFC] blktap3: support for blktap3 in libxl Makefile

[Thanos Makatos <thanos.makatos@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell
> Sent: 26 October 2012 12:19
> To: Thanos Makatos
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 03 of 16 RFC] blktap3: support for
> blktap3 in libxl Makefile
> 
> > diff -r 513739de43b5 -r 80e0bc67dcda tools/libxl/Makefile
> > --- a/tools/libxl/Makefile  Wed Oct 24 17:24:37 2012 +0100
> > +++ b/tools/libxl/Makefile  Wed Oct 24 17:24:53 2012 +0100
> > @@ -20,7 +20,7 @@ LIBUUID_LIBS += -luuid  endif
> >
> >  LIBXL_LIBS =
> > -LIBXL_LIBS = $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest)
> > $(LDLIBS_libxenstore) $(LDLIBS_libblktapctl) $(PTYFUNCS_LIBS)
> > $(LIBUUID_LIBS)
> > +LIBXL_LIBS = $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest)
> > +$(LDLIBS_libxenstore) $(PTYFUNCS_LIBS) $(LIBUUID_LIBS)
> 
> What happened to LDLIBS_libblktapctl here?

It's temporarily removed since libxl_blktap3.c provides a dummy implementation 
and re-enabled at a later patch in this series; anyway this doesn't make sense 
anymore.

> 
> >  CFLAGS_LIBXL += $(CFLAGS_libxenctrl)
> >  CFLAGS_LIBXL += $(CFLAGS_libxenguest) @@ -77,7 +77,8 @@ LIBXL_OBJS =
> > flexarray.o libxl.o libxl_c
> >                     libxl_qmp.o libxl_event.o libxl_fork.o $(LIBXL_OBJS-
> y)  LIBXL_OBJS
> > += _libxl_types.o libxl_flask.o _libxl_types_internal.o
> >
> > -$(LIBXL_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include
> > $(XEN_ROOT)/tools/config.h
> > +$(LIBXL_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include
> $(XEN_ROOT)/tools/config.h \
> > +   $(CFLAGS_libblktapctl)
> 
> This Makefile already contains
> CFLAGS_LIBXL += $(CFLAGS_libblktapctl)
> so I think this change is redundant (or else incomplete).

Correct, I missed it.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel