[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 11 of 16 RFC] blktap3: Provide empty implementation for the tap_ctl_list and tap_ctl_list_free functions


  • To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
  • From: Thanos Makatos <thanos.makatos@xxxxxxxxxx>
  • Date: Tue, 30 Oct 2012 10:29:40 +0000
  • Accept-language: en-US
  • Acceptlanguage: en-US
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 30 Oct 2012 10:30:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac2zbkfKmi0Gfz/1Q3+XO8QukA0xuQDGvo4Q
  • Thread-topic: [Xen-devel] [PATCH 11 of 16 RFC] blktap3: Provide empty implementation for the tap_ctl_list and tap_ctl_list_free functions


> -----Original Message-----
> From: Ian Campbell
> Sent: 26 October 2012 12:37
> To: Thanos Makatos
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 11 of 16 RFC] blktap3: Provide empty
> implementation for the tap_ctl_list and tap_ctl_list_free functions
> 
> On Wed, 2012-10-24 at 18:02 +0100, Thanos Makatos wrote:
> > +#ifdef HAVE_CONFIG_H
> > +#include "config.h"
> > +#endif
> 
> I think the presence of config.h will be statically determined, wont
> it?

This piece of code is present in (almost) all blktap2 (the github one) files, I 
seems related to autoconf/automake. I'll remove it.

> 
> > +
> > +#include "tap-ctl.h"
> > +
> > +void tap_ctl_list_free(__attribute__((__unused__)) struct
> > +tqh_tap_list *list) {
> > +    return;
> > +}
> > +
> > +int tap_ctl_list(__attribute__((__unused__)) struct tqh_tap_list
> > +*list) {
> > +    return -ENOSYS;
> > +}
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.