Re: [Xen-devel] [PATCH 01 of 16 RFC] blktap3: Introduce the blktap3 device type

[Thanos Makatos <thanos.makatos@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell
> Sent: 26 October 2012 12:17
> To: Thanos Makatos
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 01 of 16 RFC] blktap3: Introduce the
> blktap3 device type
> 
> On Wed, 2012-10-24 at 18:02 +0100, Thanos Makatos wrote:
> > This device is used when tap is specifed as the disk backend, instead
> of vbd.
> >
> > diff -r 3cd5bf62ded7 -r fef81de66bf7 tools/libxl/libxl.c
> > --- a/tools/libxl/libxl.c   Wed Oct 24 17:22:39 2012 +0100
> > +++ b/tools/libxl/libxl.c   Wed Oct 24 17:24:01 2012 +0100
> > @@ -1742,7 +1742,7 @@ int libxl__device_from_disk(libxl__gc *g
> >              device->backend_kind = LIBXL__DEVICE_KIND_VBD;
> >              break;
> >          case LIBXL_DISK_BACKEND_TAP:
> > -            device->backend_kind = LIBXL__DEVICE_KIND_VBD;
> > +            device->backend_kind = LIBXL__DEVICE_KIND_XENIO;
> 
> Presumably as well as this change a bunch of related infrastructure
> changes are needed? I'd suggest putting all those first and making this
> switch at the end, so that xl remains functional at each point in the
> series.

Ok these changes will be part of the final "switch to blktap3" patch.

> 
> >              break;
> >          case LIBXL_DISK_BACKEND_QDISK:
> >              device->backend_kind = LIBXL__DEVICE_KIND_QDISK; diff -r
> > 3cd5bf62ded7 -r fef81de66bf7 tools/libxl/libxl_types_internal.idl
> > --- a/tools/libxl/libxl_types_internal.idl  Wed Oct 24 17:22:39
> 2012 +0100
> > +++ b/tools/libxl/libxl_types_internal.idl  Wed Oct 24 17:24:01
> 2012 +0100
> > @@ -19,6 +19,7 @@ libxl__device_kind = Enumeration("device
> >      (5, "VFB"),
> >      (6, "VKBD"),
> >      (7, "CONSOLE"),
> > +    (8, "XENIO"),
> 
> I know this is what it is called internally but for libxl purposes can
> we use BLKTAP or something descriptive like that?

Sure.

> 
> >      ])
> >
> >  libxl__console_backend = Enumeration("console_backend", [
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel