Re: [Xen-devel] [Patch 4/5] X86/vMCE: handle broken page occurred before migration

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Jan Beulich wrote:
>>>> On 29.10.12 at 16:21, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
>> X86/vMCE: handle broken page occurred before migration
>> 
>> This patch handles guest broken page which occur before migration.
>> 
>> At sender, the broken page would be mapped but not copied to target
>> (otherwise it may trigger more serious error, say, SRAR error).
>> While its pfn_type and pfn number would be transferred to target
>> so that target take appropriate action.
>> 
>> At target, it would set p2m as p2m_ram_broken for broken page, so
>> that if guest access the broken page again, it would kill itself as
>> expected. 
>> 
>> Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>
> 
> So I continue to be confused - wasn't the agreement you
> reached with George that patch 5 re-done makes patch 4
> unnecessary?
> 

No, the agreement is,
old patch 5 don't need re-do, it's OK to handle 'vmce occur before migration',
old patch 4 need update a little, it's used to handle 'vmce occur during 
migration', but need updated as 'not abort migration';

===============
BTW, this time I adjust the sequence of patch 4 and 5, since the new approach 
for 'vmce occur during migration' rely on some logic of 'vmce occur before 
migration'.

So latest patch 4 and 5 are:
patch 4 (same as old patch 5, no update): handle 'vmce occurred before 
migration';
patch 5 (updated old patch 4, according to George's suggestion): handle 'vmce 
occurs during migration' -- it updated a little for old patch 4 -- it didn't 
abort migration, instead it mark the broken page to dirty bitmap, so that at 
copypages stage of migration, the pfn_type and pfn number of broken page would 
transfer to target and then take appropriate action;

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel