Re: [Xen-devel] [PATCH 0 of 5] xl shutdown compatibility with xm

[Sander Eikelenboom <linux@xxxxxxxxxxxxxx>]

Friday, October 19, 2012, 12:21:45 PM, you wrote:

> Ian Campbell writes ("Re: [PATCH 0 of 5] xl shutdown compatibility with xm"):
>> On Mon, 2012-10-15 at 12:21 +0100, Sander Eikelenboom wrote:
>> >     - On shutdown with xl as toolstack and when the guest doesn't
>> > support pv shutdown, the init.d/xendomains script doesn't even attempt
>> > to shutdown this guest by acpi fallback.
>> >     - As a result when using xl as toolstack, the guest is terminated
>> > non gracefully when the whole machine finally shutsdown, which seems
>> > less desirable then at least *trying* to shut it down gracefully by
>> > using the acpi button.
>> 
>> Using the ACPI fallback is a decision which can only be made locally
>> with full knowledge of the configuration of the guests.

> I'm still with Sander on this, I'm afraid.

> Certainly in the init scripts the default should be to try
>  xl shutdown -F
> and only do destroy if that didn't seem to work.

So Ian, what would your prefer ?

A) only fix the xendomains init script, since it's automated and a administator 
can not intervene, for manual usage of xl shutdown keep the current behaviour
B) Drop the -F option and let xl shutdown always try the acpi fallback. In this 
case you can very well turn around IanC's argumentation:
   An administrator who knows that a domain can't be shutdown with either the 
pv or acpi fallback just shouldn't try to use xl shutdown manually.
   (and if he does probably nothing devastating will happen)
C) Invert the -F option, to NOT try to use the apci fallback

I think option B is acceptable and preferable:
  - It reduces config options
  - Will work out of the box in most cases (for domains without PV drivers), 
since most of the time the acpi power button event is wired correctly.
  - In most cases nothing devastating will happen when it doesn't work.
  - Only in very special cases, probably setup explicitly, a admin should 
shutdown the domain by other means, but he has that knowledge in those cases
    and shouldn't use xl shutdown on that domain, and shut the domain down 
before shutting down the machine (and running the xendomains init script)

--
Sander



> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel