Re: [Xen-devel] [PATCH 4/5] xen: arm: implement remap interfaces needed for privcmd mappings.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-10-25 at 01:07 +0100, Mukesh Rathor wrote:
> On Wed, 24 Oct 2012 16:44:11 -0700
> Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> 
> > >  
> > >  #ifndef HYPERVISOR_VIRT_START
> > > diff --git a/include/xen/interface/memory.h
> > > b/include/xen/interface/memory.h index ad0dff5..5de2b36 100644
> > > --- a/include/xen/interface/memory.h
> > > +++ b/include/xen/interface/memory.h
> > > @@ -188,6 +188,24 @@ DEFINE_GUEST_HANDLE_STRUCT(xen_add_to_physmap);
> > >  /*** REMOVED ***/
> > >  /*#define XENMEM_translate_gpfn_list  8*/
> > >  
> > > +#define XENMEM_add_to_physmap_range 23
> > > +struct xen_add_to_physmap_range {
> > > +    /* Which domain to change the mapping for. */
> > > +    domid_t domid;
> > > +    uint16_t space; /* => enum phys_map_space */
> > > +
> > > +    /* Number of pages to go through */
> > > +    uint16_t size;
> > > +    domid_t foreign_domid; /* IFF gmfn_foreign */
> > > +
> > > +    /* Indexes into space being mapped. */
> > > +    GUEST_HANDLE(xen_ulong_t) idxs;
> > > +
> > > +    /* GPFN in domid where the source mapping page should appear.
> > > */
> > > +    GUEST_HANDLE(xen_pfn_t) gpfns;
> > 
> > 
> > Looking at your arm implementation in xen, doesn't look like you are
> > expecting idxs and gpfns to be contigous. In that case, shouldn't idxs
> > and gpfns be pointers, ie, they are sent down as arrays? Or does
> > GUEST_HANDLE do that, I can't seem to find where it's defined quickly.
> 
> Never mind, I see it got corrected to XEN_GUEST_HANDLE in staging tree.

The macro is called XEN_GUEST_HANDLE in Xen and just GUEST_HANDLE in
Linux.

> Still doesn't compile tho:
> 
> public/memory.h:246: error: expected specifier-qualifier-list before
> â__guest_handle_xen_ulong_tâ
> 
> I'll figure it out.

Looks like you've got it all sorted?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel