Re: [Xen-devel] [PATCH] xen-netback: allow changing the MAC address of the interface

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-10-19 at 18:34 +0100, Matt Wilson wrote:
> Reported-by: Nikita Borzykh <sample.n@xxxxxxxxx>
> Reported-by: Paul Harvey <stockingpaul@xxxxxxxxxxx>
> Suggested-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

I can't remember that but it seems reasonable:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

But, can you remind us of the usecase? Perhaps in the commit message?

Lastly, netback patches should be sent to netdev@xxxxxxxxxxxxxxx as per
MAINTAINERS in order to be applied.

Thanks,
Ian.


> Signed-off-by: Matt Wilson <msw@xxxxxxxxxx>
> ---
>  drivers/net/xen-netback/interface.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c 
> b/drivers/net/xen-netback/interface.c
> index b7d41f8..f733cae 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
>       .ndo_stop       = xenvif_close,
>       .ndo_change_mtu = xenvif_change_mtu,
>       .ndo_fix_features = xenvif_fix_features,
> +     .ndo_set_mac_address = eth_mac_addr,
> +     .ndo_validate_addr   = eth_validate_addr,
>  };
>  
>  struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel