[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Make restore work properly with PV superpage flag

On Thursday, October 18, 2012, George Dunlap wrote:
> Looks good -- boy, when you know that all of your pages have to be
> superpages, it makes the logic a lot easier. :-)  Unfortunately that's
> not the case for HVM guests, so we need to keep the complicated
> detection logic.
> I was trying to think of a way to make the "hvm" and "superpage" based
> on the desired behavior (e.g, "detect_superpages",
> "always_superpages", or something like that), rather than having to
> encode "!hvm && superpage" all over the place, but I think in the end
> the way you've written it is fine.

Yeah, I spent a lot of time trying to make some integrated way to do both 
types of allocation, but finally gave up and kept the two code paths separate.  
In the end I think it's cleaner that way.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.