Re: [Xen-devel] [PATCH 4/6] xen: correctly use xen_pfn_t in remap_domain_mfn_range.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 17 Oct 2012, Ian Campbell wrote:
> For Xen on ARM a PFN is 64 bits so we need to use the appropriate
> type here.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

In general every mfn/pfn type should be xen_pfn_t, we might have to do a
closer audit of the code.


>  arch/x86/xen/mmu.c    |    2 +-
>  include/xen/xen-ops.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 1c5812b..d779e96 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -2603,7 +2603,7 @@ static int remap_area_mfn_pte_fn(pte_t *ptep, pgtable_t 
> token,
>  
>  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
>                              unsigned long addr,
> -                            unsigned long mfn, int nr,
> +                            xen_pfn_t mfn, int nr,
>                              pgprot_t prot, unsigned domid,
>                              struct page **pages)
>  
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index 6a40253..dc63e80 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -26,7 +26,7 @@ void xen_destroy_contiguous_region(unsigned long vstart, 
> unsigned int order);
>  struct vm_area_struct;
>  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
>                              unsigned long addr,
> -                            unsigned long mfn, int nr,
> +                            xen_pfn_t mfn, int nr,
>                              pgprot_t prot, unsigned domid,
>                              struct page **pages);
>  int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
> -- 
> 1.7.2.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel