Re: [Xen-devel] [PATCH 2 of 5] xl: Introduce xl shutdown --all support for xm compatibility

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH 2 of 5] xl: Introduce xl shutdown --all support 
for xm compatibility"):
> xl: Introduce xl shutdown --all support for xm compatibility
...> 
> Based on a patch by Sander Eikelenboom
...
>  int main_shutdown(int argc, char **argv)
...
> +        if (wait_for_it)
> +            deathws = calloc(nb_domain, sizeof(deathws));

This should read sizeof(*deathws).  It's a shame we don't have a macro
to avoid this broken pattern in xl.  In libxl we have GCNEW_ARRAY of
course.  (In fact in this particular case the two things are both
pointers so the sizeof() is the same and the bug is theoretical.)

Apart from that,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel