Re: [Xen-devel] [PATCH 01/10] xen: arm: implement XENMEM_add_to_physmap_range

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-10-17 at 16:31 +0100, Stefano Stabellini wrote:
> On Mon, 15 Oct 2012, Ian Campbell wrote:
> > diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
> > index 86d02c8..f1ddbc0 100644
> > --- a/xen/include/public/memory.h
> > +++ b/xen/include/public/memory.h
> > @@ -198,6 +198,15 @@ struct xen_machphys_mapping {
> >  typedef struct xen_machphys_mapping xen_machphys_mapping_t;
> >  DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t);
> >  
> > +/* Source mapping space. */
> > +/* ` enum phys_map_space { */
> 
> I don't think that these comments about the enum add any value.

They are part of the infrastructure which generates useful symlinks and
cross references in http://xenbits.xen.org/docs.

> 
> In any case the patch is simple and seems correct so:
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Thanks.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel