Re: [Xen-devel] [PATCH 10/10] arm: parameter guest handles are 32 bit on 32 bit hypervisor

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 17 Oct 2012, Ian Campbell wrote:
> On Wed, 2012-10-17 at 14:50 +0100, Stefano Stabellini wrote:
> > On Mon, 15 Oct 2012, Ian Campbell wrote:
> > > Handles within structs remain 64 bit such that they are consistently
> > > sized on both 32 and 64 bit.
> > > 
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > ---
> > >  xen/include/public/arch-arm.h |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > > index ac493a5..ff02d15 100644
> > > --- a/xen/include/public/arch-arm.h
> > > +++ b/xen/include/public/arch-arm.h
> > > @@ -74,7 +74,7 @@
> > >  #define __XEN_GUEST_HANDLE(name)        __guest_handle_64_ ## name
> > >  #define XEN_GUEST_HANDLE(name)          __XEN_GUEST_HANDLE(name)
> > >  /* this is going to be changed on 64 bit */
> > > -#define XEN_GUEST_HANDLE_PARAM(name)   XEN_GUEST_HANDLE(name)
> > > +#define XEN_GUEST_HANDLE_PARAM(name)    __guest_handle_ ## name
> > >  #define set_xen_guest_handle_raw(hnd, val)                  \
> > >      do {                                                    \
> > >          typeof(&(hnd)) _sxghr_tmp = &(hnd);                 \
> > 
> > I am confused.
> > 
> > I am not sure what version of my patch "xen: introduce
> > XEN_GUEST_HANDLE_PARAM" you have based this series upon, because the
> > latest one I have sent, certainly contains this change:
> 
> That stuff is in "xen: introduce XEN_GUEST_HANDLE_PARAM". I had to defer
> the final switch until after the transition to HANDLE_PARAM was complete
> in order to avoid breaking the build in the interim.

I see.
Also I noticed that you wrote that in the commit message of "xen:
introduce XEN_GUEST_HANDLE_PARAM", so it is OK by me.


Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel