Re: [Xen-devel] [PATCH 01/10] xen: xenbus: quirk uses x86 specific cpuid

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.10.12 at 10:39, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> --- a/drivers/xen/xenbus/xenbus_xs.c
> +++ b/drivers/xen/xenbus/xenbus_xs.c
> @@ -619,6 +619,8 @@ static struct xenbus_watch *find_watch(const char *token)
>  
>       return NULL;
>  }
> +
> +#ifdef CONFIG_X86
>  /*
>   * Certain older XenBus toolstack cannot handle reading values that are
>   * not populated. Some Xen 3.4 installation are incapable of doing this
> @@ -637,6 +639,10 @@ static bool xen_strict_xenbus_quirk()
>       return false;
>  
>  }
> +#else
> +static bool xen_strict_xenbus_quirk(void) { return false; }
> +#endif

Wouldn't it reduce redundancy if the #ifdef block was inserted
inside the existing function?

Jan

> +
>  static void xs_reset_watches(void)
>  {
>       int err, supported = 0;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel