[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 3 of 8] blktap: fix rpmlint warning spurious-executable-perm

  • To: xen-devel@xxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Mon, 15 Oct 2012 15:44:21 +0200
  • Delivery-date: Mon, 15 Oct 2012 13:45:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

# HG changeset patch
# User Olaf Hering <olaf@xxxxxxxxx>
# Date 1350303963 -7200
# Node ID ba9b347a31fed0aa57604d2342117282dd38b9bc
# Parent  71ecc69cf74a0845d8825c7e73f3e5ca16cd4b76
blktap: fix rpmlint warning spurious-executable-perm

[ 1758s] xen-devel.x86_64: E: spurious-executable-perm (Badness: 50) 
[ 1758s] The file is installed with executable permissions, but was identified 
as one
[ 1758s] that probably should not be executable.  Verify if the executable bits 
[ 1758s] desired, and remove if not. NOTE: example scripts should be packaged 
[ 1758s] %docdir/examples, which will avoid this warning.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

diff -r 71ecc69cf74a -r ba9b347a31fe tools/blktap/lib/Makefile
--- a/tools/blktap/lib/Makefile
+++ b/tools/blktap/lib/Makefile
@@ -23,23 +23,25 @@ OBJS     = $(SRCS:.c=.o)
 OBJS_PIC = $(SRCS:.c=.opic)
 IBINS   :=
-LIB      = libblktap.a libblktap.so.$(MAJOR).$(MINOR)
+LIB      = libblktap.a
+LIB_SO   = libblktap.so.$(MAJOR).$(MINOR)
 .PHONY: all
-all: $(LIB)
+all: $(LIB) $(LIB_SO)
 .PHONY: install
 install: all
        ln -sf libblktap.so.$(MAJOR).$(MINOR) 
        ln -sf libblktap.so.$(MAJOR) $(DESTDIR)$(LIBDIR)/libblktap.so
        $(INSTALL_DATA) blktaplib.h $(DESTDIR)$(INCLUDEDIR)
 .PHONY: clean
-       rm -rf *.a *.so* *.o *.opic *.rpm $(LIB) *~ $(DEPS) xen TAGS
+       rm -rf *.a *.so* *.o *.opic *.rpm $(LIB) $(LIB_SO) *~ $(DEPS) xen TAGS
 libblktap.so.$(MAJOR).$(MINOR): $(OBJS_PIC) 

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.