Re: [Xen-devel] [PATCH 4 of 8] xen: allow for explicitly specifying node-affinity

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

Could you trim your quotes please?

> > diff --git a/xen/xsm/flask/include/av_perm_to_string.h 
> > b/xen/xsm/flask/include/av_perm_to_string.h
> > --- a/xen/xsm/flask/include/av_perm_to_string.h
> > +++ b/xen/xsm/flask/include/av_perm_to_string.h
> > @@ -37,8 +37,8 @@
> >     S_(SECCLASS_DOMAIN, DOMAIN__TRANSITION, "transition")
> >     S_(SECCLASS_DOMAIN, DOMAIN__MAX_VCPUS, "max_vcpus")
> >     S_(SECCLASS_DOMAIN, DOMAIN__DESTROY, "destroy")
> > -   S_(SECCLASS_DOMAIN, DOMAIN__SETVCPUAFFINITY, "setvcpuaffinity")
> > -   S_(SECCLASS_DOMAIN, DOMAIN__GETVCPUAFFINITY, "getvcpuaffinity")
> > +   S_(SECCLASS_DOMAIN, DOMAIN__SETAFFINITY, "setaffinity")
> > +   S_(SECCLASS_DOMAIN, DOMAIN__GETAFFINITY, "getaffinity")
> 
> The top of this file says, "This file is automatically generated. Do
> not edit."  I didn't see any files that might have been modified to
> effect these changes -- did I miss them?  Or is the comment a lie?  Or
> should you find that file and edit it instead? :-)

Also, in that case why is this file checked in?

Usually the reason is if the generating tool is not widely available,
but in this case it seems to be
tools/flask/policy/policy/flask/mkflask.sh which depends on awk and not
a lot else -- so I think we can rely on it being available.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel