Re: [Xen-devel] [PATCH] stubdom: fix error assignment in grub:load_module

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Olaf Hering, le Tue 09 Oct 2012 15:04:29 +0200, a écrit :
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1349787855 -7200
> # Node ID 384714804b9b2a9742cc45dffaa43b749b85513b
> # Parent  142e4577f5a9b95832b82f7b6d31fde1697cbe76
> stubdom: fix error assignment in grub:load_module
> 
> [ 1333s] mini-os.c: In function 'load_module':
> [ 1333s] mini-os.c:244: warning: statement with no effect
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> diff -r 142e4577f5a9 -r 384714804b9b stubdom/grub/mini-os.c
> --- a/stubdom/grub/mini-os.c
> +++ b/stubdom/grub/mini-os.c
> @@ -241,7 +241,7 @@ load_module (char *module, char *arg)
>  
>      if ((void*) (multiboot_next_module_header+1) - module_image > PAGE_SIZE) 
> {
>          /* Too many modules */
> -        ERR_WONT_FIT;
> +        errnum = ERR_WONT_FIT;
>          return 0;
>      }
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

-- 
Samuel
/* Halley */

        (Halley's comment.)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel