Re: [Xen-devel] [PATCH 11/14] arm: implement remap interfaces needed for privcmd mappings.

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Fri, 5 Oct 2012 14:42:30 +0100
Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> On Fri, 2012-10-05 at 14:36 +0100, Stefano Stabellini wrote:
> [... snip dozens of pointless lines -- please trim your quotes...]
> 
> > > - return -ENOSYS;
> > > + int err;
> > > + struct remap_data data;
> > > +
> > > + /* TBD: Batching, current sole caller only does page at
> > > a time */
> > > + if (nr > 1)
> > > +         return -EINVAL;
> > 
> > It looks like that this implementation of
> > xen_remap_domain_mfn_range is capable of handling nr > 1, so why
> > this return -EINVAL?
> 
> Hrm, yes. I think I just blindly copied that from the pvh
> implementation.
> 
> [...]

PVH was using a different mechanism earlier, pfn from high up memory
address space. So it was doing one at a time. It can be removed now.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel