[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3 of 8] xen: let the (credit) scheduler know about `node affinity`

>>> On 05.10.12 at 16:08, Dario Faggioli <dario.faggioli@xxxxxxxxxx> wrote:
> @@ -287,22 +344,26 @@ static inline void
>          }
>          else
>          {
> -            cpumask_t idle_mask;
> +            cpumask_t idle_mask, balance_mask;

Be _very_ careful about adding on-stack CPU mask variables
(also further below): each one of them grows the stack frame
by 512 bytes (when building for the current maximum of 4095
CPUs), which is generally too much; you may want to consider
pre-allocated scratch space instead.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.