Re: [Xen-devel] [PATCH 08/14] xen: balloon: allow PVMMU interfaces to be compiled out

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 5 Oct 2012, Stefano Stabellini wrote:
> On Fri, 5 Oct 2012, Ian Campbell wrote:
> > On Fri, 2012-10-05 at 14:19 +0100, Stefano Stabellini wrote:
> > > On Thu, 4 Oct 2012, Ian Campbell wrote:
> > > > The ARM platform has no concept of PVMMU and therefor no
> > > > HYPERVISOR_update_va_mapping et al. Allow this code to be compiled out
> > > > when not required.
> > > > 
> > > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > 
> > > I am unsure whether it is worth a new symbol and two ifdef's
> > 
> > ARM doesn't compile without it, since HYPERVISOR_update_va_mapping
> > doesn't exist. Do you have a preferable alternative?
> > 
> > I'm not sure how much more of this sort of thing there will be as we
> > enable more features on the ARM port.
> 
> #define HYPERVISOR_update_va_mapping(va, new_val, flags) (0)
> 

actually a proper static line with a BUG would be better

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel