[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] fix public header hvm/save.h to be compatible with c++

>>> On 05.10.12 at 15:21, Ben Guthro <ben@xxxxxxxxxx> wrote:
> On Fri, Oct 5, 2012 at 9:13 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 05.10.12 at 14:46, Ben Guthro <ben@xxxxxxxxxx> wrote:
>>> Thanks for your review. Comments addressed, and re-tested.
>> But now I fail to see why the rename is still necessary
> I left the rename in there because you said you didn't mind them.
> I was unsure if this meant you preferred the rename, or not. In the
> interest of minimizing code churn to just the minimum - the ifdef
> would be sufficient.
> However, since you suggested I also fix the spacing around the equal
> signs, I thought that the variable rename was in the same category,
> for "code cleanup"
> I think this is just a misunderstanding.
> Would you like to see a third patch with just the ifdef?

I'll leave that decision to Keir, as it's going to be him to apply
(or at least ack) the change anyway.

> Also - as a matter of procedure, should I reply to this original
> thread when iterating on a patch like this, or start a new one, with
> [PATCH v2] etc?

Afaic, that's up to your preference.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.