[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3 03/10] libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL.

On Wed, 2012-09-26 at 19:15 +0100, Anthony PERARD wrote:
> Those two JSON_TRUE and JSON_FALSE were types of node. But it's better to have
> a unique JSON_BOOL type.
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Is it valid to call libxl__json_object_get_bool (and all the similar
functions) with a wrongly typed thing? The other types seem to return
NULL as an error indicator. The bool case just returns false.

Just wondering if maybe there ought to be an assert in each of those?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.