Re: [Xen-devel] [PATCH 03/14] xen events: xen_callback_vector is x86 specific

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 4 Oct 2012, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
> Should instead move somewhere arch specific?

This shouldn't be needed: it should be already protected by
CONFIG_XEN_PVHVM (that is x86 specific).


>  drivers/xen/events.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 6f55ef2..2508981 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -1775,6 +1775,7 @@ int xen_set_callback_via(uint64_t via)
>  EXPORT_SYMBOL_GPL(xen_set_callback_via);
>  
>  
> +#ifdef CONFIG_X86
>  /* Vector callbacks are better than PCI interrupts to receive event
>   * channel notifications because we can receive vector callbacks on any
>   * vcpu and we don't need PCI support or APIC interactions. */
> @@ -1798,6 +1799,9 @@ void xen_callback_vector(void)
>                       alloc_intr_gate(XEN_HVM_EVTCHN_CALLBACK, 
> xen_hvm_callback_vector);
>       }
>  }
> +#else
> +void xen_callback_vector(void) {}
> +#endif
>  
>  void xen_init_IRQ(void)
>  {
> -- 
> 1.7.2.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel