Re: [Xen-devel] [PATCH 2/6] xen-blkfront: handle backend CLOSED without CLOSING

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.09.12 at 19:53, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> @@ -1167,7 +1168,8 @@ blkfront_closing(struct blkfront_info *info)
>  
>       mutex_lock(&bdev->bd_mutex);
>  
> -     if (bdev->bd_openers) {
> +     /* If the backend is already CLOSED, close now. */
> +     if (bdev->bd_openers && backend_state != XenbusStateClosed) {
>               xenbus_dev_error(xbdev, -EBUSY,
>                                "Device in use; refusing to close");
>               xenbus_switch_state(xbdev, XenbusStateClosing);

This looks wrong to me on a second glance: As long as there
are users of the device, I don't think we want to go into Closed
ourselves, irrespective of the backend state.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel