Re: [Xen-devel] [PATCH 01/11] Add ioread/iowrite functions to mini-os

[Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>]

On 10/02/2012 05:10 AM, Ian Campbell wrote:
> On Fri, 2012-09-28 at 14:57 +0100, Matthew Fioravante wrote:
>> On 09/28/2012 06:16 AM, George Dunlap wrote:
>>> On Thu, Sep 27, 2012 at 6:09 PM, Matthew Fioravante
>>> <matthew.fioravante@xxxxxxxxxx> wrote:
>>>> This patch adds iowritexx() and ioreadxx() functions for interacting
>>>> with hardware memory to mini-os. The functions are available in a header
>>>> iorw.h
>>>>
>>>> Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
>>>> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
>>>>
>>>> diff --git a/extras/mini-os/arch/ia64/iorw.c 
>>>> b/extras/mini-os/arch/ia64/iorw.c
>>> Is there any reason to have the ia64 stuff? ia64 isn't supported in
>>> Xen anymore, AFAIK.
>> Maybe not. But until ia64 support is removed from mini-os the function
>> bodies should exist so stuff will compile.
> I thought I had dropped all the remnants of ia64 in mini-os in commit
> 25882:485e6db28b93 "tools: drop ia64 support". Let me know if you think
> I've missed something, but:
>
>>>> new file mode 100644
>>>> index 0000000..aa58807
>>>> --- /dev/null
>>>> +++ b/extras/mini-os/arch/ia64/iorw.c
> $ ls extras/mini-os/arch/ia64/iorw.c
> ls: cannot access extras/mini-os/arch/ia64/iorw.c: No such file or directory
>
> I think perhaps you just need to rebase?
Sorry about that, I missed that entirely. These patches were written a
long time ago when ia64 was still in and since iorw.c never existed in
the first place the patch just happily added it. Anyway, its been removed.
> Ian.
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel