Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers. [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Paul Durrant writes ("RE: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to 
serve as the    register of product numbers."):
> Ok. I thought it was helpful to reserve product number 0 for this purpose, 
> but I'll ditch it.

Well if you want to reserve it you could put a comment in the list
saying "0 is reserved, do not use".

Paul Durrant writes ("Re: [Xen-devel] [PATCH] Use new Xen public header for 
product numbers     and names"):
> Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]:
> > As a case in point, this generates:
> >        case 0: product = NULL; break;
> > and then passes the NULL to asprintf.
> 
> Nothing should be using product number 0, so is this a problem?

You're joking, right ?

The guest can send any value it likes here and the result is that qemu
might dereference NULL.  (Although in practice asprintf doesn't
crash on NULL strings in any implementation I'm aware of.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel