Re: [Xen-devel] [PATCH 18/23] arch/x86: Add missing mem_sharing XSM hooks

[Tim Deegan <tim@xxxxxxx>]

At 12:11 -0400 on 27 Sep (1348747909), Daniel De Graaf wrote:
> > I think this ought to be at least IS_PRIV_FOR.  I can see the original
> > code allowed all callers to use it, but surely it ought to be only for
> > the tools.  Since only the tools can actually set the mem-access rights
> > (and so this is pretty much a noop) I don't think this causes any
> > substantial problem but we might as well adjust it anyway.
> > 
> > Tim.
> 
> Because this is a domctl, it already requires IS_PRIV as checked by 
> xsm_domctl (and was already checked before this series).

OK; in that case you have my ack on this. 

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel