[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/HPET: don't disable interrupt delivery right after setting it up



>>> On 27.09.12 at 16:49, Malcolm Crossley <malcolm.crossley@xxxxxxxxxx> wrote:
> On 27/09/12 15:40, Jan Beulich wrote:
>> We shouldn't clear HPET_TN_FSB right after we (indirectly, via
>> request_irq()) enabled it for the channels we intend to use for
>> broadcasts.
>>
>> This fixes a regression introduced by c/s 25103:0b0e42dc4f0a.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> This fixes the MWAIT idle driver problem on the box that I was able to
>> (artificially) reproduce it with. Hence I subsequently intend to revert
>> 25960:6bf8b882df8f, but I'm not intending to do this before getting a
>> push there.
>>
>> I'm surprised that this didn't hit anyone so far with the ACPI-based
>> idle driver...
> Good catch Jan, Does this fix need backporting to Xen 4.2 and 4.1?

Definitely to 4.2. Didn't check yet whether the offending patch got
backported to 4.1.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.