Re: [Xen-devel] [PATCH 0 of 3] xl and hotplug: Introduce and use shutdown and reboot xm compatibility options

[Sander Eikelenboom <linux@xxxxxxxxxxxxxx>]

Tuesday, September 25, 2012, 11:35:12 AM, you wrote:

> On Thu, 2012-09-06 at 20:41 +0100, Sander Eikelenboom wrote:
>> The /etc/init.d/xendomains script makes use of options for the
>> shutdown command defined in xendomains-sysconfig/default.
>> These options were not implemented in xl, this patch series implements
>> the options and by using the short variant makes it compatible with
>> both xm and xl.
>> 
>> Signed-off-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>

> Hi Sander,

> Are you still looking into the review feedback on these patches?

> Ian.

Hi Ian,

Yes but had a little time last week and i'm a bit stuck on IanJ's comment  :-(


> This isn't quite right, I think.  Surely it should initiate the
> shutdown for all the domains right away, and then wait for them all to
> finish ?
>
> That's going to make the patch more complicated of course...
>
> Ian.

The only relative simple implementation i thought of was direct shutting down 
all, and when the -w parameter was set, just loop and wait on events until the 
only running domain is domain-0.
Although this exactly does what has to be done, it somehow sounds a bit dirty.


--
Sander


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel