Re: [Xen-devel] [PATCH xm/xl enhancements for vptm 5/6] make devid a libxl type

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-09-21 at 20:20 +0100, Matthew Fioravante wrote:
> This fixes a bug in libxl where device ids are not initialized properly.
> The devid field for each device is set to be an integer type which are
> always initialized to 0.
> 
> This makes the xl DEV-attach commands always fail to add more than one
> device, because each time the device id is initialized to 0, when it
> should be initialized to -1, which in the code will trigger a search for
> free id.

Which of the DEV-attach commands can be used to add more than one
device?

Where is the code to do the search? I had a look in the disk and network
cases and couldn't find it.

> diff --git a/tools/ocaml/libs/xs/xs.mli b/tools/ocaml/libs/xs/xs.mli
> --- a/tools/ocaml/libs/xs/xs.mli
> +++ b/tools/ocaml/libs/xs/xs.mli
> @@ -27,6 +27,7 @@ exception Failed_to_connect
>  type perms = Xsraw.perms
>  
>  type domid = int
> +type devid = int

I can see why these were needed in the xl modules, but I don't see how
this type can be required in the xenstore ones.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel