Re: [Xen-devel] [PATCH] x86: retrieve keyboard shift status flags from BIOS

[Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>]

> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> (but also see below)
.. snip..
> > flags. */
> >  struct xenpf_firmware_info {
> >     /* IN variables. */
> >     uint32_t type;
> > @@ -142,6 +143,8 @@ struct xenpf_firmware_info {
> >                     /* must refer to 128-byte buffer */
> >                     GUEST_HANDLE(uchar) edid;
> >             } vbeddc_info; /* XEN_FW_VBEDDC_INFO */
> > +           uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
> > +
> 
> I'd prefer to not have stray empty line here - if anything, it should
> go before the new union member.
> 

Done! Thx for the review.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel