Re: [Xen-devel] [PATCH] x86: enable VIA CPU support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.09.12 at 14:55, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 21/09/2012 12:40, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> Newer VIA CPUs have both 64-bit and VMX support. Enable them to be
>> recognized for these purposes, at once stripping off any 32-bit CPU
>> only bits from the respective CPU support file.
>> 
>> This particularly implies untying the VMX == Intel assumption in a few
>> places.
> 
> Why can't we use 'cpu_has_vmx' instead of your strcmp construct?

Honestly, I didn't even notice we had this (if it's there, I would
have expected it to be used instead of vendor checks).

> It strikes me if it's safe to use in the one place it already is
> (HVM_CR4_GUEST_RESERVED_BITS) then it should be safe for your use too. If
> it's not then it's probably unsafe in its current use, and we should change
> the definition of cpu_has_vmx in a preparatory patch.

Indeed - I'll adjust the patch accordingly.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel