Re: [Xen-devel] [PATCH] ACPI: move tables.c fully into .init.*

[Keir Fraser <keir@xxxxxxx>]

On 19/09/2012 13:57, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> On 19.09.12 at 13:40, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
>> On 19/09/2012 09:58, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> 
>>> Of course, if you're only against the dynamic allocation, moving
>>> the array elsewhere would be another option (but would require
>>> making the symbol global, whereas here the symbol goes away
>>> altogether from the symbol tables).
>>> 
>>> Yet another option would be to do the dynamic allocation where
>>> it was actually intended to be done, passing NULL here. The
>>> resizing there isn't being made use of anyway (and wouldn't
>>> work afaict), so we could as well do away with it and replace it
>>> by the simple allocation needed here (or simply fix it,
>>> considering that we might need it at some point).
>> 
>> I'm not wild about any of the options really. Perhaps passing NULL would be
>> best. Still, overall, I'm not *that* bothered. You can have my Ack for the
>> original patch:
>> Acked-by: Keir Fraser <keir@xxxxxxx>
> 
> As you were not really happy with it, and as I (also already in
> the past) wondered about when the broken re-allocation there
> would hit us, I decided to produce a v2, fixing and using the
> re-allocation mechanism instead.

I like that more, yes. Thanks!

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel