[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] ACPI: move tables.c fully into .init.*


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Wed, 19 Sep 2012 08:56:15 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Wed, 19 Sep 2012 07:56:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac2WPD48jV6epEipakycicp/W9WBHw==
  • Thread-topic: [Xen-devel] [PATCH] ACPI: move tables.c fully into .init.*

On 19/09/2012 08:29, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> On 18.09.12 at 17:42, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
>> On 18/09/2012 16:26, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> 
>>> The only non-init item was the space reserved for the initial tables,
>>> but we can as well dynamically allocate that array.
>>> 
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> Really worthwhile, versus having to round up the initial_tables[] allocation
>> to a whole number of pages?
> 
> It was exactly one page in size already.

Well, still I'm not sure about the style of converting static data to heap
data, just to be able to mark a whole unit init-only. If everything else is
already  marked init inside that file already, is there a win?

 -- Keir

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.