Re: [Xen-devel] Problems building qemu-xen-dir tools

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Sep 18, M A Young wrote:

> On Tue, 18 Sep 2012, Olaf Hering wrote:
> 
> >On Wed, Sep 19, Steven Haigh wrote:
> >
> >>Without this, the build fails due to incompatible CFLAGS.
> >
> >CFLAGS must not be in environment, otherwise make will append its own
> >CFLAGS to that environment variable and pass it on to qemu. qemu itself
> >is not ready for things like -std=gnu99.
> 
> The problem is that packaging guidelines often want you to set CFLAGS to
> supply distribution standard compile options. On the other hand with
> something like qemu it means that someone has probably already solved the
> problem. The attached patch worked for me in testing, which I derived by
> comparing Fedora's qemu with xen's.

qemu does not build with rPM_OPT_FLAGS, at least in SuSE.
For Xen, see changeset:   25464:75a2bb5db228
user:        Olaf Hering <olaf@xxxxxxxxx>
date:        Thu Jun 07 18:51:42 2012 +0100
files:       tools/Makefile tools/Rules.mk tools/firmware/Rules.mk
description:
tools: pass EXTRA_CFLAGS via environment


Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel