Re: [Xen-devel] [PATCH vtpm_manager 2/2] Fixes to vtpm hotplug scripts

[Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>]

On 09/18/2012 03:43 AM, Ian Campbell wrote:
> On Mon, 2012-09-17 at 22:19 +0100, Matthew Fioravante wrote:
>> This patch fixes IO deadlocks in the vtpm hotplug scripts
> Is the switch from awk to gawk a part of this? How?
>
> IIRC we deliberately switched from using gawk specific features to allow
> e.g. mawk to be used. If there is some gawk specific construct used here
> it would be better to recast it in more portable terms IMHO.
I'll test and get back to you on this.
>
>> - set -e
>> + local resp_hex
>> + #send cmd to vtpm_manager and get response
>> + if ! resp_hex=`echo "$cmd$(str_to_hex32 $inst)" | vtpmmgrtalk `; then
> Is this really the command/control interface provided by VTPM? Can we
> not work with upstream to define something more usable?
Unfortunately xen itself is the upstream for vtpm_manager. The
vtpm_manager code is full of bugs and actually needs a complete rewrite.
The amount of careless memory leaks and other bugs I found when trying
to use it were pretty astounding. The first manager patch fixes most of
the ones I could find to get the manager to work properly.

The managers current form in the xen tree is actually pretty unusable.
I don't have time to rewrite the manager, but what I'm offering here is
at least a huge improvement over the old code.
>
> Ian.
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel