[Xen-devel] Saving domain in xl does not have proper cleanup

[Bastian Blank <waldi@xxxxxxxxxx>]

Hi

Saving a domain without enough available space with xl in 4.2-rc5 fails
to cleanup completely. The domain informations remains in Xenstore,
the domain itself seems to remain in a suspended state and there is not
xl process for it anymore.

Reason is the use of the MUST macro in save_domain. It exits the process
prematurely instead of cleaning up the external visible changes.

Also the MUST macro is broken. exit() only takes "values & 0xff", so
this macro may exit the process with 0 if the error value is chosen
unwisely.

Bastian

-- 
A princess should not be afraid -- not with a brave knight to protect her.
                -- McCoy, "Shore Leave", stardate 3025.3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel