Re: [Xen-devel] [RFC PATCH 3/8]: PVH: memory manager and paging related changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-16 at 02:02 +0100, Mukesh Rathor wrote:
> 
> +/* Map foreign gmfn, fgmfn, to local pfn, lpfn. This for the user
> space
> + * creating new guest on PVH dom0 and needs to map domU pages. Called
> from
> + * exported function, so no need to export this.
> + */
> +static int pvh_add_to_xen_p2m(unsigned long lpfn, unsigned long
> fgmfn,
> +                             unsigned int domid)
> +{
> +       int rc;
> +       struct xen_add_to_physmap pmb = {.foreign_domid = domid};
> +
> +       pmb.gpfn = lpfn;
> +       pmb.idx = fgmfn;
> +       pmb.space = XENMAPSPACE_gmfn_foreign;

You've not initialised pmb.domid here. I think you want/need to set it
to DOMID_SELF and have the h/v side behave accordingly.

> +       rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap, &pmb); 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel