Re: [Xen-devel] [PATCH] use spaces instead of tabs in vim

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 14 Sep 2012, Ian Campbell wrote:
> On Thu, 2012-09-13 at 18:58 +0100, Stefano Stabellini wrote:
> > On Thu, 13 Sep 2012, Ian Jackson wrote:
> > > Thanos Makatos writes ("[Xen-devel] [PATCH] use spaces instead of tabs in 
> > > vim"):
> > > > Tell vim to use spaces instead of tabs for all files residing under
> > > > xen-unstable.hg. Must open files from the top-level directory, 
> > > > otherwise it
> > > > doesn't work.
> > > 
> > > This is fine by me and looks plausible but I'd like to see a second
> > > opinion from someone who uses vim.
> > > 
> > 
> > Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> http://vim.wikia.com/wiki/Modeline_magic suggests you can do it on a
> per-file basis. Given the number of different coding styles throughout
> the tree wouldn't that be a better option?

I agree that would be a better option.


> This set of options is wrong
> e.g. for tools/libxl and anything imported from Linux.

That's right, it would be wrong for Linux, but I think it is correct for
libxl and QEMU (both use 4 whitespaces for indentation), so in practice it
should be correct for anything under xen-unstable except Makefiles and
stuff imported as-is from Linux (xen/arch/arm/lib/* for example). Better
than nothing :)


> It's be a bigger initial patch but once it is done it's done.
> 
> People typically copy the magic block from an existing file so as long
> as you put the vim one next to the emacs one it should get propagated as
> necessary to new files.
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel