Re: [Xen-devel] [PATCH 09/22] xsm: Use the dummy XSM module if XSM is disabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.12 at 17:59, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> This patch moves the implementation of the dummy XSM module to a header
> file that provides inline functions when XSM_ENABLE is not defined. This
> reduces duplication between the dummy module and callers when the
> implementation of the dummy return is not just "return 0", and also
> provides better compile-time checking for completeness of the XSM
> implementations in the dummy module.

This looks good to me, with one minor comment:

> --- a/xen/xsm/xsm_core.c
> +++ b/xen/xsm/xsm_core.c
> @@ -113,7 +113,7 @@ int unregister_xsm(struct xsm_operations *ops)
>  
>  long do_xsm_op (XEN_GUEST_HANDLE(xsm_op_t) op)
>  {
> -    return __do_xsm_op(op);
> +    return xsm___do_xsm_op(op);

The three immediately successive underscores look really odd
now - any reason a single one doesn't do?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel