Re: [Xen-devel] [PATCH 1 of 2 v3] tools: check for documentation generation tools at configure time

[Matt Wilson <msw@xxxxxxxxxx>]

On Mon, Sep 10, 2012 at 05:09:10PM +0100, Ian Campbell wrote:
> 
> > diff -r d7e4efa17fb0 -r 3b3582f4dc42 tools/m4/docs_tool.m4
> > --- /dev/null       Thu Jan 01 00:00:00 1970 +0000
> > +++ b/tools/m4/docs_tool.m4 Thu Sep 06 21:31:51 2012 -0700
> > @@ -0,0 +1,10 @@
> > +# $1: autoconf variable name
> > +# $2: list of programs to check for
> > +AC_DEFUN([AX_DOCS_TOOL_PROGS], [
> > +dnl
> > +    AC_ARG_VAR([$1], [Path to ] m4_tolower($1) [ tool])
> > +    AC_PATH_PROGS([$1], [$2])
> > +    AS_IF([! test -x "$ac_cv_path_$1"], [
> > +        AC_MSG_WARN([$2 is not available so some documentation won't be 
> > built])
> 
> Did you mean m4_tolower($1) for this last $2 as well? Since $2 is the
> list of potential command names this will look a bit odd I think?

Yea, that could be better. Though I kind of like that it shows the
programs that were checked. It'd look like:
 
 markdown markdown_py is not available so some documentation won't be built

Maybe just drop 'is' to avoid the verb mismatch.

Matt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel