Re: [Xen-devel] [PATCH] libxl: fix error message in device_backend_callback

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-09-04 at 16:29 +0100, Roger Pau Monne wrote:
> device_backend_callback error path always says "unable to disconnect",
> but this can also happen during the connection of a device. Fix the
> error message using the information in aodev->action.
> 
> Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
and applied.

Jan, can we consider this one for 4.2.1 please.

Ian.

> ---
>  tools/libxl/libxl_device.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
> index 8e8410e..c3283f1 100644
> --- a/tools/libxl/libxl_device.c
> +++ b/tools/libxl/libxl_device.c
> @@ -854,7 +854,8 @@ static void device_backend_callback(libxl__egc *egc, 
> libxl__ev_devstate *ds,
>      }
>  
>      if (rc) {
> -        LOG(ERROR, "unable to disconnect device with path %s",
> +        LOG(ERROR, "unable to %s device with path %s",
> +                   aodev->action == DEVICE_CONNECT ? "connect" : 
> "disconnect",
>                     libxl__device_backend_path(gc, aodev->dev));
>          goto out;
>      }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel