Re: [Xen-devel] [patch 3/3] xen/privcmd: remove const modifier from declaration

[Andres Lagar-Cavilla <andreslc@xxxxxxxxxxxxxx>]

On Sep 8, 2012, at 5:58 AM, Dan Carpenter wrote:

> When we use this pointer, we cast away the const modifier and modify the
> data.  I think it was an accident to declare it as const.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>

Thanks for the careful review & hardening.
Andres

> 
> diff --git a/include/xen/privcmd.h b/include/xen/privcmd.h
> index a853168..58ed953 100644
> --- a/include/xen/privcmd.h
> +++ b/include/xen/privcmd.h
> @@ -69,7 +69,7 @@ struct privcmd_mmapbatch_v2 {
>       unsigned int num; /* number of pages to populate */
>       domid_t dom;      /* target domain */
>       __u64 addr;       /* virtual address */
> -     const xen_pfn_t __user *arr; /* array of mfns */
> +     xen_pfn_t __user *arr; /* array of mfns */
>       int __user *err;  /* array of error codes */
> };
> 
> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index 0ce006a..fceb83e 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -389,7 +389,7 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, 
> int version)
> 
>       if (state.global_error && (version == 1)) {
>               /* Write back errors in second pass. */
> -             state.user_mfn = (xen_pfn_t *)m.arr;
> +             state.user_mfn = m.arr;
>               state.err      = err_array;
>               ret = traverse_pages(m.num, sizeof(xen_pfn_t),
>                                    &pagelist, mmap_return_errors_v1, &state);


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel