[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] VT-d: split .ack and .disable DMA-MSI actors



>>> On 07.09.12 at 17:05, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 07/09/2012 13:45, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> Calling irq_complete_move() from .disable is wrong, breaking S3 resume.
>> 
>> Comparing with all other .ack actors, it was also missing a call to
>> move_{native,masked}_irq(). As the actor is masking its interrupt
>> anyway (albeit it's not immediately obvious why), the latter is the
>> better choice.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> As far as I understand it
> Acked-by: Keir Fraser <keir@xxxxxxx>
> 
> I guess you are looking for an Intel ack as well.

Yes, that's why I Cc-ed Xiantao.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.