Re: [Xen-devel] [PATCH] kexec/noreboot: Don't kexec_crash() if noreboot has been requested.

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 07/09/2012 14:16, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> On 07.09.12 at 15:05, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> This issue came up when debugging pcpu linked list corruption (patches
>> for that issue to follow).
> 
> Hmm, that's a matter of taste of course. Nor is running kdump
> really a (direct) reboot action. Both ways have their reasoning
> imo, so I'm not sure whether keeping things as is or applying the
> patch is the better thing.

I note though that kexec_crash() should be stubbed out in the header file
when !CONFIG_KEXEC, rather than ifdef at the caller. By the by.

 -- Keir

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel