Re: [Xen-devel] [PATCH 12/16] arm: const-correctness in virt_to_maddr

[Tim Deegan <tim@xxxxxxx>]

At 13:30 +0000 on 03 Sep (1346679052), Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  xen/include/asm-arm/mm.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
> index b0e5a67..7440fe5 100644
> --- a/xen/include/asm-arm/mm.h
> +++ b/xen/include/asm-arm/mm.h
> @@ -179,9 +179,9 @@ extern void clear_fixmap(unsigned map);
>  #define paddr_to_pdx(pa)    pfn_to_pdx(paddr_to_pfn(pa))
>  
>  
> -static inline paddr_t virt_to_maddr(void *va)
> +static inline paddr_t virt_to_maddr(const void *va)
>  {
> -    uint64_t par = va_to_par((uint32_t)va);
> +    uint64_t par = va_to_par((const uint32_t)va);

This second const is unnecessary (or else you also need one in the cast
on the next line).  For the first one, though:

Acked-by: Tim Deegan <tim@xxxxxxx> 

>      return (par & PADDR_MASK & PAGE_MASK) | ((unsigned long) va & 
> ~PAGE_MASK);
>  }
>  
> -- 
> 1.7.9.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel