Re: [Xen-devel] [PATCH] make domain_create() return a proper error code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> > @@ -237,7 +238,7 @@ void __init start_xen(unsigned long boot
> >  
> >      /* Create initial domain 0. */
> >      dom0 = domain_create(0, 0, 0);
> > -    if ( dom0 == NULL )
> > +    if ( IS_ERR(dom0) )
> >              printk("domain_create failed\n");
> >      if ( (dom0 == NULL) || (alloc_dom0_vcpu0() == NULL) )
> 
> You probably wanted to change this one too?
> 
> I'm not sure the first message really buys much -- I'd be happy to nuke
> it too.

8<------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1346662775 -3600
# Node ID c4e822e1b491bb7efa962b38fff6f007f01596b5
# Parent  241186e96a1ece42ad3bd14901b62d872f4abd9e
arm: correctly check for error on dom0 allocation

Drop the redundant printk

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 241186e96a1e -r c4e822e1b491 xen/arch/arm/setup.c
--- a/xen/arch/arm/setup.c      Mon Sep 03 09:57:33 2012 +0100
+++ b/xen/arch/arm/setup.c      Mon Sep 03 09:59:35 2012 +0100
@@ -238,9 +238,7 @@ void __init start_xen(unsigned long boot
 
     /* Create initial domain 0. */
     dom0 = domain_create(0, 0, 0);
-    if ( IS_ERR(dom0) )
-            printk("domain_create failed\n");
-    if ( (dom0 == NULL) || (alloc_dom0_vcpu0() == NULL) )
+    if ( IS_ERR(dom0) || (alloc_dom0_vcpu0() == NULL) )
             panic("Error creating domain 0\n");
 
     dom0->is_privileged = 1;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel