Re: [Xen-devel] [PATCH] libxl: fix api check Makefile

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-08-31 at 16:06 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: fix api check Makefile"):
> > On Fri, 2012-08-31 at 15:38 +0100, Ian Jackson wrote:
> > > @@ -116,12 +117,13 @@ $(eval $(genpath-target))
> > >  libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
> > >   $(PERL) $^
> > > + touch $@
> > 
> > libxl.api-ok needs to either go in .*ignore or start with an _.
> 
> Duh, don't know how I missed that.
> 
> > Otherwise this looks good:
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Subject: [PATCH v2] libxl: fix api check Makefile
> 
> Touch the libxl.api-ok stamp file, and unconditionally put in place
> the new _libxl.api-for-check.  This avoids needlessly rerunning the
> preprocessor on libxl.h each time we call "make".
> 
> Ensure that _libxl.api-for-check gets the CFLAGS used for xl, so that
> if it is asked for in a standalone make run it can find xentoollog.h.
> 
> Remove *.api-ok on clean.
> 
> Also fix .gitignore.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> --
> v2: add api-ok to gitignore

Needs to be in hgignore too. Sorry!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel