Re: [Xen-devel] [TESTDAY] xl cpupool-create segfaults if given invalid configuration

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [TESTDAY] xl cpupool-create segfaults if 
given invalid configuration"):
> I think the issue is the parser has:
>         %destructor { xlu__cfg_set_free($$); }  value valuelist values
> which frees the current "setting" but does not remove it from the list
> of settings.

Sorry for this, this is my fault and I have dropped the fix.

> diff -r af7143d97fa2 tools/libxl/libxlu_cfg_y.y
> --- a/tools/libxl/libxlu_cfg_y.y      Tue Aug 14 15:59:38 2012 +0100
> +++ b/tools/libxl/libxlu_cfg_y.y      Wed Aug 15 17:34:25 2012 +0100
> @@ -47,7 +47,7 @@
>  file: /* empty */
>   |     file setting
>  
> -setting: IDENT '=' value      { xlu__cfg_set_store(ctx,$1,$3,@3.first_line); 
> }
> +setting: IDENT '=' value      { xlu__cfg_set_store(ctx,$1,$3,@3.first_line); 
> $3 = NULL; }

I don't think this is correct.  It may happen to work with this
version of bison but I don't think you're allowed to assign to $3.

Looking at the code I think this handling of the XLU_ConfigSettings
and flex is all wrong.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel