Re: [Xen-devel] [RFC] Spurious PIC interrupts

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 29/08/2012 10:08, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:

>> No, you should make the change to _mask_and_ack_8259A_irq() itself, and
>> callers which do not care about the return code can simply discard it.
> 
> Ok - I initially avoided that because _mask_and_ack_8259A_irq() is used
> to fill a function pointer structure, and preferred less change to the core.
> 
> I will re-design somewhat with these points in mind.

Worst case rename to __mask_and_ack_8259A_irq() and implement new
_mask_and_ack_8259A_irq() which simply calls it and discards the return
code. Still much better than duplicating the function.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel