Re: [Xen-devel] [PATCH, v2] x86/HVM: assorted RTC emulation adjustments

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.08.12 at 19:34, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
>>> wrote:
>> > because it would be nice to be able to backport features like this one:
>> > 
>> > http://marc.info/?l=qemu-devel&m=134392375010304 
>> 
>> I agree this would be nice to have (albeit I'm not sure how much
>> the original problem is actually present in the Xen code, particularly
>> with the patch here applied, as I think it may implicitly clean up some
>> of the unneccesary active timers).
> 
> Maybe, but with your patch applied, are there going to be any timers
> running if the guest is not making use of the RTC?

Can't tell without in depth analysis, as I didn't pay too much
attention to this aspect of the code. I just vaguely recall that
in at least one case the changes might have resulted in not
re-arming a timer under some condition where it previously
got re-armed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel